test: skip flaky hotplug tests on 5.10 hosts#6007
Merged
ShadowCurse merged 2 commits intoJun 30, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6007 +/- ##
=======================================
Coverage 83.08% 83.08%
=======================================
Files 277 277
Lines 30201 30201
=======================================
Hits 25094 25094
Misses 5107 5107
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
not4s
added
the
Status: Awaiting review
zulinx86
reviewed
Jun 30, 2026
zulinx86
left a comment
zulinx86
left a comment
Contributor
There was a problem hiding this comment.
I thought we only want to skip it on 5.10 host. Does it also fail on 6.1/6.18 hosts?
Contributor
Author
|
@zulinx86 Nope just the 5.10. Should we just skip it for 5.10 hosts? |
Manciukic
reviewed
Jun 30, 2026
not4s
force-pushed
the
fix/skip-flaky-virtio-mem-hotplug
branch
from
a29587b to
7531d6e
Compare
not4s
changed the title
zulinx86
previously approved these changes
Jun 30, 2026
11 tasks
test_virtio_mem_hotplug_hotunplug and test_memory_hotplug_latency intermittently fail on x86_64 5.10 hosts, where the GET /hotplug/memory API call exceeds the maximum duration assertion. Skip both there until the latency is investigated. Signed-off-by: Jay Chung <jaehoc@amazon.com>
not4s
force-pushed
the
fix/skip-flaky-virtio-mem-hotplug
branch
from
7531d6e to
a574423
Compare
ShadowCurse
previously approved these changes
Jun 30, 2026
zulinx86
previously approved these changes
Jun 30, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
cargo-audit flags RUSTSEC-2026-0190, failing the security audit on all branches. anyhow is not a direct dependency of any Firecracker crate; it is only pulled in transitively by build-time WASM tooling (wit-bindgen), so we are not affected. Ignore it to unblock CI. Signed-off-by: Jay Chung <jaehoc@amazon.com>
zulinx86
approved these changes
Jun 30, 2026
ShadowCurse
approved these changes
Jun 30, 2026
Manciukic
approved these changes
Jun 30, 2026
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
test_virtio_mem_hotplug_hotunplugandtest_memory_hotplug_latencyon 5.10 hosts.RUSTSEC-2026-0190to.cargo/audit.tomlignore list.Reason
Both tests intermittently fail on 5.10 hosts, where the
GET /hotplug/memoryAPI call exceeds the maximum duration assertion (the unplug request gets queued behind the VMM thread and the API call waits). Skip until the RC is investigated.The cargo-audit ignore is bundled here to unblock the merge queue: RUSTSEC-2026-0190 (anyhow) was published and is failing
test_cargo_auditon all PRs. anyhow is not a direct dependency of any Firecracker crate; it is only pulled in transitively by build-time WASM tooling (wit-bindgen).License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.